fixes AWS logs module ACL error on creation #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralren
approved these changes
Dec 13, 2023
avanti-joshi
approved these changes
Dec 13, 2023
|
merge this pls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug AWS logs module ACL error
Cleaning up an error while creating the tf logs bucket. Ownership of bucket must be "ObjectWriter" instead of the default "BucketOwnerEnforced" if creating/using an acl.
Note: using ACLs will be finally deprecated in some major change to the terraform provider and we should consider how we create these buckets.